Page MenuHomePhabricator

Add example of datetime paritioned schedule
ClosedPublic

Authored by sashank on Oct 21 2019, 10:02 PM.

Details

Test Plan

Turned on schedule, verified message was sent to slack

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

love the crypto data example :) see comments

examples/dagster_examples/experimental/repo.py
18

remove?

98

hmmm should we model this as something other than an Expectation?

102

are these floats? might be integer division in py2

119

py2: I think you need https://stackoverflow.com/a/6289494/11295366 to use emoji in a python file

128

remove?

This revision is now accepted and ready to land.Oct 21 2019, 10:35 PM
sashank added inline comments.
examples/dagster_examples/experimental/repo.py
98

keeping this as is as per our discussion

119

removed

128

keeping this as a placeholder for the bug

sashank marked 3 inline comments as done.

feedback

schrockn added inline comments.
examples/dagster_examples/experimental/sched.py
18

this is actually a great pattern. this is a pretty good argument for having the .py file creates yaml which creates config pattern

nate added inline comments.
examples/dagster_examples/experimental/repo.py
18

nit: should this be uppercase since it's a top-level constant? or maybe just put it inside bq_solid since its only used there

110

maybe add an OutputDefinition(Nothing) to this solid to avoid this Output(1) for now?

examples/dagster_examples/experimental/repo.py
18

Yup should be uppercase. I think we have to keep it outside so that we can pass it to the solid decorator's metadata arg.