Page MenuHomePhabricator

Add example of datetime paritioned schedule
ClosedPublic

Authored by sashank on Oct 21 2019, 10:02 PM.

Details

Test Plan

Turned on schedule, verified message was sent to slack

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sashank created this revision.Oct 21 2019, 10:02 PM
nate accepted this revision.Oct 21 2019, 10:35 PM

love the crypto data example :) see comments

examples/dagster_examples/experimental/repo.py
19

remove?

99

hmmm should we model this as something other than an Expectation?

103

are these floats? might be integer division in py2

120

py2: I think you need https://stackoverflow.com/a/6289494/11295366 to use emoji in a python file

129

remove?

This revision is now accepted and ready to land.Oct 21 2019, 10:35 PM
sashank marked 5 inline comments as done.Oct 22 2019, 12:19 AM
sashank added inline comments.
examples/dagster_examples/experimental/repo.py
99

keeping this as is as per our discussion

120

removed

129

keeping this as a placeholder for the bug

sashank updated this revision to Diff 5954.Oct 22 2019, 12:19 AM
sashank marked 3 inline comments as done.

feedback

sashank edited the test plan for this revision. (Show Details)Oct 22 2019, 12:19 AM
schrockn added inline comments.
examples/dagster_examples/experimental/sched.py
19

this is actually a great pattern. this is a pretty good argument for having the .py file creates yaml which creates config pattern

nate accepted this revision.Oct 23 2019, 6:37 PM
nate added inline comments.
examples/dagster_examples/experimental/repo.py
19

nit: should this be uppercase since it's a top-level constant? or maybe just put it inside bq_solid since its only used there

111

maybe add an OutputDefinition(Nothing) to this solid to avoid this Output(1) for now?

sashank added inline comments.Oct 23 2019, 6:39 PM
examples/dagster_examples/experimental/repo.py
19

Yup should be uppercase. I think we have to keep it outside so that we can pass it to the solid decorator's metadata arg.