Page MenuHomePhabricator

[RunLauncher] basic interface
ClosedPublic

Authored by alangenfeld on Oct 17 2019, 7:17 PM.

Details

Reviewers
schrockn
Group Reviewers
Restricted Project
Commits
R1:fe39eebe49e4: [RunLauncher] basic interface
Summary

Adds the basic interface for a RunLauncher to be loaded by an instance and available via GraphQL.

Test Plan

test case

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Oct 17 2019, 7:17 PM
alangenfeld planned changes to this revision.Oct 17 2019, 8:02 PM
alangenfeld updated this revision to Diff 5888.Oct 17 2019, 9:42 PM

make graphql

my only question is here the relationship between "enqueued" and "startScheduled" execution. what if you want to have the "StartScheduled" one actually enqueue

I actually think enqueueing should probably be the default behavior?

ya thats a good question Im not sure the right answer to, seems like the options are:

  • bool flag on startScheduled or moral equivalent
  • startScheduled uses run_queue if its present otherwise starts directly
  • remove execution_manager in dagster-graphql to run_queue and remove the distinction between start and enqueue from the whole system
prha added a subscriber: prha.Oct 22 2019, 4:45 PM

my vote is for option 2...

Run queue is an optional plugin, correct?

alangenfeld planned changes to this revision.Oct 28 2019, 4:25 PM

execution_delegate version

schrockn accepted this revision.Nov 20 2019, 11:49 PM

good start

python_modules/dagster-graphql/dagster_graphql/implementation/execution.py
213

unnecessary? won't the create_execution_plan call pick up the error?

This revision is now accepted and ready to land.Nov 20 2019, 11:49 PM

run launcher version

python_modules/dagster-graphql/dagster_graphql/implementation/execution.py
153–158

*

213

copy pasta from above

alangenfeld retitled this revision from [RunQueue] basic interface to [RunLauncher] basic interface.Nov 20 2019, 11:58 PM
alangenfeld edited the summary of this revision. (Show Details)
alangenfeld updated this revision to Diff 6764.Nov 21 2019, 4:53 PM

test against none set

alangenfeld updated this revision to Diff 6770.Nov 21 2019, 5:38 PM

add predefined query

This revision was automatically updated to reflect the committed changes.