Page MenuHomePhabricator

[RunQueue] basic interface
Changes PlannedPublic

Authored by alangenfeld on Oct 17 2019, 7:17 PM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

Adds the basic interface for a RunQueue to be loaded by an instance and available via GraphQL.

Test Plan

test case

Diff Detail

Repository
R1 dagster
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

alangenfeld created this revision.Oct 17 2019, 7:17 PM
alangenfeld planned changes to this revision.Oct 17 2019, 8:02 PM
alangenfeld updated this revision to Diff 5888.Oct 17 2019, 9:42 PM

make graphql

my only question is here the relationship between "enqueued" and "startScheduled" execution. what if you want to have the "StartScheduled" one actually enqueue

I actually think enqueueing should probably be the default behavior?

ya thats a good question Im not sure the right answer to, seems like the options are:

  • bool flag on startScheduled or moral equivalent
  • startScheduled uses run_queue if its present otherwise starts directly
  • remove execution_manager in dagster-graphql to run_queue and remove the distinction between start and enqueue from the whole system
prha added a subscriber: prha.Tue, Oct 22, 4:45 PM

my vote is for option 2...

Run queue is an optional plugin, correct?

alangenfeld planned changes to this revision.Mon, Oct 28, 4:25 PM