Page MenuHomePhabricator

Rename execution_epoch_time
AbandonedPublic

Authored by natekupp on Oct 11 2019, 9:15 PM.

Details

Reviewers
schrockn
Group Reviewers
Restricted Project
Test Plan

unit

Diff Detail

Repository
R1 dagster
Branch
exc_time
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

natekupp created this revision.Oct 11 2019, 9:15 PM
natekupp added a reviewer: Restricted Project.Oct 12 2019, 12:22 AM
schrockn requested changes to this revision.Oct 12 2019, 12:26 AM
schrockn added subscribers: sashank, schrockn.

we should hold off on this until @sashank makes forward progress with the date-time partitioning next week (tied to the scheduler). i think "Execution time" sounds like the time that the computation is occuring. I.e. if the computation were happening on oct-1 but processing the data from sept 15, I would guess that "Execution time" means oct 1, which is the opposite of this as I understand it.

This revision now requires changes to proceed.Oct 12 2019, 12:26 AM
natekupp abandoned this revision.Mon, Oct 28, 5:23 PM
natekupp added a subscriber: prha.

I'm going to drop this—after discussing with @prha given the run config cleanup he's doing, I would prefer to rip all of this out entirely.

Instead of threading RunConfig through the config mapping context, we should have:

  1. A "pure" parent -> child config mapping API
  2. In @sashank 's work to create unit of work APIs, we should provide a way to wire Airflow's execution date up to config construction