Page MenuHomePhabricator

[RFC] dagster-graphql --remote HOST
ClosedPublic

Authored by alangenfeld on Oct 10 2019, 8:02 PM.

Details

Reviewers
natekupp
Group Reviewers
Restricted Project
Commits
R1:49ab884411dd: [RFC] dagster-graphql --remote HOST
Summary

Add the ability for dagster-graphql CLI to target a remote dagit server and execute GraphQL against it.

Test Plan
$ dagster-graphql -r http://localhost:3333 -t {__typename}
{'data': {'__typename': 'Query'}}

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Oct 10 2019, 8:02 PM
alangenfeld updated this revision to Diff 5765.Oct 10 2019, 8:43 PM

isort skip

natekupp accepted this revision.Oct 12 2019, 12:24 PM
natekupp added a subscriber: natekupp.

LGTM, but see one comment

python_modules/dagster-graphql/dagster_graphql/cli.py
114

hmm should we make this an info endpoint with dagit version, etc. as a JSON response? I could see it being useful to have a generic "tell me about yourself" endpoint which also happens to tell us that the server is dagit

This revision is now accepted and ready to land.Oct 12 2019, 12:24 PM
alangenfeld updated this revision to Diff 5824.Mon, Oct 14, 6:22 PM

more useful sanity check endpoint

This revision was automatically updated to reflect the committed changes.