Page MenuHomePhabricator

Add css ellipsis for run pipeline name
ClosedPublic

Authored by prha on Wed, Oct 9, 11:30 PM.

Details

Reviewers
schrockn
bengotow
Group Reviewers
Restricted Project
Commits
R1:2c896e52c4d5: Add css ellipsis for run pipeline name
Summary

Runs view:

Schedules view:

Test Plan

rendered runs table in narrow view

Diff Detail

Repository
R1 dagster
Branch
prha/ellipsis
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

prha created this revision.Wed, Oct 9, 11:30 PM

can you post screenshot?

prha updated this revision to Diff 5751.Thu, Oct 10, 12:38 AM

update to handle schedule tags, schedule view

prha updated this revision to Diff 5752.Thu, Oct 10, 12:58 AM

update to remove ellipsis from schedule toggle cell

prha edited the summary of this revision. (Show Details)Thu, Oct 10, 1:02 AM
alangenfeld added subscribers: bengotow, alangenfeld.

@bengotow you have thoughts here?

js_modules/dagit/src/ListComponents.tsx
33–50

can we use composition instead of a toggle here? Also whats up with * {...} is that some css child shit?

js_modules/dagit/src/schedules/SchedulesRoot.tsx
207

is this the same as noellipsis=true?

prha added inline comments.Thu, Oct 10, 3:48 PM
js_modules/dagit/src/ListComponents.tsx
33–50

Yeah, * { ... } is some CSS bullshit, so that nested elements get the ellipsis also (I'll see if I can switch * to div). This helps when you have something wrapping text (like a <Tooltip /> wrapper div, or a <Tag /> token with long text.

I'm not sure about the composition piece here. It depends on what we want the default column behavior to be.

js_modules/dagit/src/schedules/SchedulesRoot.tsx
207

yep!

prha updated this revision to Diff 5754.Thu, Oct 10, 3:56 PM
prha edited the summary of this revision. (Show Details)

@alangenfeld's comments... restrict ellipsis to block elements (divs) and get rid of the toggle

prha updated this revision to Diff 5755.Thu, Oct 10, 4:21 PM

rebase

prha updated this revision to Diff 5762.Thu, Oct 10, 6:57 PM

rebase

bengotow accepted this revision.Fri, Oct 11, 3:54 PM

This looks good to me! πŸ‘

This revision is now accepted and ready to land.Fri, Oct 11, 3:54 PM
This revision was automatically updated to reflect the committed changes.