Page MenuHomePhabricator

ensure `on_complete` called for completed compute log subscriptions
ClosedPublic

Authored by prha on Oct 9 2019, 7:13 PM.

Details

Summary

Previously, we were calling on_complete for observers only if the step compute completed
after the observer had subcribed. This change checks for compute completion upon subscription and
calls on_complete accordingly

Test Plan

Opened logs for historical runs, saw complete calls fire.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

prha created this revision.Oct 9 2019, 7:13 PM
prha retitled this revision from make sure we call `on_complete` for observers subscribing to historical runs to ensure `on_complete` called for completed compute log subscriptions.Oct 9 2019, 8:03 PM
prha added a reviewer: Restricted Project.
alangenfeld accepted this revision.Oct 9 2019, 9:10 PM
This revision is now accepted and ready to land.Oct 9 2019, 9:10 PM