Page MenuHomePhabricator

Revert "Revert "Consolidate split panel handling, save divider locations to local storage""
ClosedPublic

Authored by bengotow on Wed, Oct 9, 6:22 PM.

Details

Summary

This re-applies https://dagster.phacility.com/D1216 and fixes infinite height adjustment by adding an explicit height to the LogsScrollingTable. For some reason this is required in Chrome but was working fine in FF.

Test Plan

View runs page

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bengotow created this revision.Wed, Oct 9, 6:22 PM
bengotow edited the summary of this revision. (Show Details)Wed, Oct 9, 6:24 PM
alangenfeld accepted this revision.Wed, Oct 9, 6:30 PM
alangenfeld added a subscriber: alangenfeld.

round 2 lets go

This revision is now accepted and ready to land.Wed, Oct 9, 6:30 PM