Page MenuHomePhabricator

Change default scrolling behavior
ClosedPublic

Authored by prha on Tue, Oct 8, 12:24 AM.

Details

Reviewers
alangenfeld
Group Reviewers
Restricted Project
Commits
R1:a05b487c54b3: Change default scrolling behavior
Summary

This diff smooths out some behavior from the scrolling of the compute log viewer:

  • Scrolls through logs using keyboard (space - shift-space)
  • Default scrolls to bottom
  • Adds a "Scroll To Top" clickable toast upon upward scroll that jumps to the top

Test Plan

Tried scrolling through logs both through live and historic runs, switching between stdout/stderr

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

prha created this revision.Tue, Oct 8, 12:24 AM
prha updated this revision to Diff 5712.Tue, Oct 8, 12:36 AM

tests

prha edited the summary of this revision. (Show Details)Tue, Oct 8, 12:41 AM
prha added a reviewer: Restricted Project.
alangenfeld accepted this revision.Wed, Oct 9, 6:27 PM
alangenfeld added a subscriber: alangenfeld.

whynot

This revision is now accepted and ready to land.Wed, Oct 9, 6:27 PM
prha updated this revision to Diff 5737.Wed, Oct 9, 7:55 PM

rebase

This revision was automatically updated to reflect the committed changes.