Page MenuHomePhabricator

Add dagster schedule restart command
ClosedPublic

Authored by sashank on Oct 7 2019, 6:35 PM.

Details

Summary

Adds dagster schedule restart and dagster schedule restart --restart-all-running commands to the dagster cli. This is to make Dockerfiles cleaner for users.

Currently they have to write:

for name in `/usr/local/bin/dagster schedule list --name --running`; do
    echo $name;
    /usr/local/bin/dagster schedule stop $name;
    /usr/local/bin/dagster schedule start $name;
done

Now, they can instead just have:

/usr/local/bin/dagster schedule restart --restart-all-running
Test Plan

run dagster schedule restart and dagster schedule restart --restart-all-running in the toys repository

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sashank created this revision.Oct 7 2019, 6:35 PM
sashank updated this revision to Diff 5685.Oct 7 2019, 8:27 PM

Add changelog message

sashank added a child revision: Restricted Differential Revision.Oct 7 2019, 11:02 PM

This lgtm, but can you add a test for this?

sashank planned changes to this revision.Oct 7 2019, 11:33 PM

yup, will add a test

sashank updated this revision to Diff 5703.Oct 7 2019, 11:46 PM

Add tests

natekupp accepted this revision.Oct 7 2019, 11:59 PM
This revision is now accepted and ready to land.Oct 7 2019, 11:59 PM