Page MenuHomePhabricator

[RFC] capture_dauphin_error returns PythonError
ClosedPublic

Authored by alangenfeld on Mon, Oct 7, 4:12 PM.

Details

Reviewers
schrockn
Group Reviewers
Restricted Project
Commits
R1:65503e06f77d: [RFC] capture_dauphin_error returns PythonError
Summary

Changes @capture_dauphin_error to return uncaught exceptions as PythonError. Updates existing return types to include PythonError and removes a type that felt redundant.

Test Plan

existing tests

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Mon, Oct 7, 4:12 PM
alangenfeld retitled this revision from capture_dauphin_error returns PythonError to [RFC] capture_dauphin_error returns PythonError.Mon, Oct 7, 5:46 PM
alangenfeld edited the summary of this revision. (Show Details)
alangenfeld edited the test plan for this revision. (Show Details)
alangenfeld added a reviewer: Restricted Project.
schrockn accepted this revision.Mon, Oct 7, 6:00 PM
schrockn added a subscriber: schrockn.

very nice

This revision is now accepted and ready to land.Mon, Oct 7, 6:00 PM
This revision was automatically updated to reflect the committed changes.