Page MenuHomePhabricator

Fix schedule --start-all command
ClosedPublic

Authored by sashank on Oct 5 2019, 7:44 PM.

Details

Reviewers
natekupp
Group Reviewers
Restricted Project
Commits
R1:ceb2018a3746: Fix schedule --start-all command
Summary

Previously, all_schedules was a property on Scheduler, but it was changed to an abstract method. The reference to all_schedules was not changed from a property access to method call in the code path for the schedule --start-all cli command.

This diff fixes that and adds tests for the --start-all command

Test Plan

test_schedules_start_all

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sashank created this revision.Oct 5 2019, 7:44 PM
sashank added inline comments.Oct 6 2019, 3:14 AM
python_modules/dagster/dagster_tests/cli_tests/test_cli_commands.py
63

Not sure why this is failing lint

natekupp accepted this revision.Oct 6 2019, 3:22 AM
This revision is now accepted and ready to land.Oct 6 2019, 3:22 AM

Can you also add that this fixes this issue in the release notes for 0.6.1?

https://github.com/dagster-io/dagster/issues/1812