Page MenuHomePhabricator

add client-side compute log size cap
ClosedPublic

Authored by prha on Fri, Oct 4, 9:44 PM.

Details

Reviewers
alangenfeld
Group Reviewers
Restricted Project
Commits
R1:c51387a521de: add client-side compute log size cap
Summary

Depends on D1219

Test Plan

Set client-side cap low, saw subscription connection close, warning sign

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

prha created this revision.Fri, Oct 4, 9:44 PM
prha updated this revision to Diff 5638.Fri, Oct 4, 10:12 PM

tests

should we continue to stream logs but only retain/show the last X MB, similar to Buildkite?

sashank added inline comments.
js_modules/dagit/src/plan/ComputeLogContent.tsx
80–84

Just a very minor suggestion, but maybe change this to a link that downloads the log directly? So the user doesn't have to read this and then go find the download button everytime, and instead the action is inline with the call to action.

prha updated this revision to Diff 5642.Sat, Oct 5, 12:46 AM

update based on comments

alangenfeld accepted this revision.Mon, Oct 7, 2:56 PM
This revision is now accepted and ready to land.Mon, Oct 7, 2:56 PM
This revision was automatically updated to reflect the committed changes.