manual tested delete after both dagster-aws init, dagster-aws up, and just dagster-aws init
- Group Reviewers
- R1:491064d04791: [dagster-aws] Fix issue with keys sticking around
yah its a potential security risk because shell=true will pass unsanitized stuff directly to the underlying shell you're using—IMO not a more substantial risk than some of the other stuff we're doing in this script—in this case the risk would be that the user puts something nasty in their config yaml which is then passed along as the key_file_path here.
Could either do it this way or exceptions-as-control-flow where we have to try / except CalledProcessError since the key may not have been added to the SSH agent yet. Thoughts? you have a preference?