Page MenuHomePhabricator

Remove __init__ methods in EventLogStorage and RunStorage abcs
ClosedPublic

Authored by schrockn on Thu, Oct 3, 9:00 PM.

Details

Summary

Was causing ConfigurableClass mixins not to be called.

https://github.com/dagster-io/dagster/issues/1804

Test Plan

Load dagit on examples

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Thu, Oct 3, 9:00 PM
alangenfeld accepted this revision.Thu, Oct 3, 9:02 PM

if it passes CI lets land this but we should think through this whole set up - worth looking quick at the postgres one that the diff that added this stuff has

This revision is now accepted and ready to land.Thu, Oct 3, 9:02 PM
schrockn edited the summary of this revision. (Show Details)Thu, Oct 3, 9:02 PM

yeah i started an issue to track https://github.com/dagster-io/dagster/issues/1804