Page MenuHomePhabricator

use sigint to cancel runs
ClosedPublic

Authored by alangenfeld on Thu, Oct 3, 8:29 PM.

Details

Reviewers
schrockn
Group Reviewers
Restricted Project
Commits
R1:bbf4a07ff431: use sigint to cancel runs
Summary

This allows the executing process to unwind gracefully and update metadata correctly.

Test Plan

unit tests

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Thu, Oct 3, 8:29 PM
schrockn accepted this revision.Thu, Oct 3, 8:30 PM
schrockn added a subscriber: schrockn.

this makes much more sense.

This revision is now accepted and ready to land.Thu, Oct 3, 8:30 PM
alangenfeld updated this revision to Diff 5554.Thu, Oct 3, 8:31 PM

update test case

Harbormaster completed remote builds in B4462: Diff 5553.
This revision was automatically updated to reflect the committed changes.