Page MenuHomePhabricator

[dagster-aws] Only install dagster/dagit during dagster-aws up w/ requirements.txt parsing
ClosedPublic

Authored by nate on Oct 3 2019, 8:20 PM.

Details

Test Plan

manual

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nate created this revision.Oct 3 2019, 8:20 PM

it would be really nice to explicitly support generating the lines in requirements.txt to that can pull from a hash on github (current master)

schrockn requested changes to this revision.Oct 3 2019, 10:22 PM

yeah let's not mutate requirements.txt

This revision now requires changes to proceed.Oct 3 2019, 10:22 PM
schrockn accepted this revision.Oct 3 2019, 10:29 PM

seems reasonable

This revision is now accepted and ready to land.Oct 3 2019, 10:29 PM
schrockn requested changes to this revision.Oct 3 2019, 10:30 PM
schrockn added inline comments.
python_modules/libraries/dagster-aws/dagster_aws/cli/cli.py
136

actually here would be a good place to prompt user for master versus public pypi

This revision now requires changes to proceed.Oct 3 2019, 10:30 PM
alangenfeld added inline comments.Oct 3 2019, 10:31 PM
python_modules/libraries/dagster-aws/dagster_aws/cli/cli.py
130

Could not find dagster requirement listed

This revision is now accepted and ready to land.Oct 3 2019, 11:05 PM
This revision was landed with ongoing or failed builds.Oct 3 2019, 11:09 PM
This revision was automatically updated to reflect the committed changes.