Page MenuHomePhabricator

misc logging fixes
ClosedPublic

Authored by prha on Thu, Oct 3, 8:00 PM.

Details

Reviewers
natekupp
schrockn
Group Reviewers
Restricted Project
Commits
R1:8a481cb01335: misc logging fixes
Summary
  • does not propagate log filter event on compute log view
  • does not scroll to bottom on initial load
Test Plan
  • clicked Logs link, saw all events in event log view
  • started stdout_spew_pipeline, saw compute log view scroll with content
  • opened completed stdout_spew_pipeline, saw compute log view stay at the start

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

prha created this revision.Thu, Oct 3, 8:00 PM

"does not scroll to bottom on initial load"

hmmm not sure this is the right product decision. for a running step going down to the bottom makes it feel more alive

prha added a comment.Thu, Oct 3, 8:31 PM

@schrockn, yeah, i like that behavior also.... if the end of the file is on the screen, it will follow the output... but if it isn't, it will wait til the user scrolls to the end of the file to start following.

I'm mostly trying to avoid the scenario where i'm looking at historical runs, and it goes to the end of the file in a somewhat surprising way.

happy to drop it, also.

schrockn accepted this revision.Thu, Oct 3, 8:32 PM

kk sounds good. just wanted to flag

This revision is now accepted and ready to land.Thu, Oct 3, 8:32 PM
prha added a comment.Thu, Oct 3, 8:32 PM

yeah, i would say, try it out, and it's a one-liner to switch back if you don't like it.

sashank added a subscriber: sashank.Thu, Oct 3, 8:34 PM

could eventually do something like BK's "follow":

This revision was automatically updated to reflect the committed changes.