Page MenuHomePhabricator

Simplify init
ClosedPublic

Authored by max on Thu, Oct 3, 1:03 AM.

Details

Reviewers
alangenfeld
Group Reviewers
Restricted Project
Commits
R1:a3ab3e7370d7: Simplify init
Summary

Eliminate the from_url constructors.

Test Plan

Unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

max created this revision.Thu, Oct 3, 1:03 AM
max updated this revision to Diff 5467.Thu, Oct 3, 1:08 AM

Sigs

alangenfeld requested changes to this revision.Thu, Oct 3, 3:08 PM
alangenfeld added a subscriber: alangenfeld.

looks like this diff picked up the changes from D1151 as well so its hard to sort out the actual change it makes

This revision now requires changes to proceed.Thu, Oct 3, 3:08 PM
alangenfeld accepted this revision.Thu, Oct 3, 4:56 PM

illallowit

python_modules/dagster/dagster/core/storage/event_log.py
44

typo performed

This revision is now accepted and ready to land.Thu, Oct 3, 4:56 PM
max updated this revision to Diff 5513.Thu, Oct 3, 6:24 PM

Nits

max updated this revision to Diff 5528.Thu, Oct 3, 6:52 PM

Rebase

max updated this revision to Diff 5530.Thu, Oct 3, 6:54 PM

Black

This revision was landed with ongoing or failed builds.Thu, Oct 3, 7:00 PM
This revision was automatically updated to reflect the committed changes.