Page MenuHomePhabricator

Simplify init
ClosedPublic

Authored by max on Oct 3 2019, 1:03 AM.

Details

Reviewers
alangenfeld
Group Reviewers
Restricted Project
Commits
R1:a3ab3e7370d7: Simplify init
Summary

Eliminate the from_url constructors.

Test Plan

Unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

max created this revision.Oct 3 2019, 1:03 AM
max updated this revision to Diff 5467.Oct 3 2019, 1:08 AM

Sigs

alangenfeld requested changes to this revision.Oct 3 2019, 3:08 PM
alangenfeld added a subscriber: alangenfeld.

looks like this diff picked up the changes from D1151 as well so its hard to sort out the actual change it makes

This revision now requires changes to proceed.Oct 3 2019, 3:08 PM
alangenfeld accepted this revision.Oct 3 2019, 4:56 PM

illallowit

python_modules/dagster/dagster/core/storage/event_log.py
44

typo performed

This revision is now accepted and ready to land.Oct 3 2019, 4:56 PM
max updated this revision to Diff 5513.Oct 3 2019, 6:24 PM

Nits

max updated this revision to Diff 5528.Oct 3 2019, 6:52 PM

Rebase

max updated this revision to Diff 5530.Oct 3 2019, 6:54 PM

Black

This revision was landed with ongoing or failed builds.Oct 3 2019, 7:00 PM
Closed by commit R1:a3ab3e7370d7: Simplify init (authored by max). · Explain Why
This revision was automatically updated to reflect the committed changes.