Page MenuHomePhabricator

misc mode selector errors
ClosedPublic

Authored by prha on Oct 1 2019, 10:37 PM.

Details

Reviewers
bengotow
Group Reviewers
Restricted Project
Commits
R1:95ff37fe240a: misc mode selector errors
Summary

bypassed config validation on mode errors

Test Plan
  • ran tests
  • renamed mode definitions in local, saw selector unlocked
  • renamed mode definitions, cleared local storage

Diff Detail

Repository
R1 dagster
Branch
prha/resolve_mode
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

prha created this revision.Oct 1 2019, 10:37 PM
bengotow accepted this revision.Oct 1 2019, 11:30 PM

Looks good to me! I was seeing an exception on kwargs['mode'] so this should fix it πŸ‘

This revision is now accepted and ready to land.Oct 1 2019, 11:30 PM
This revision was automatically updated to reflect the committed changes.