Page MenuHomePhabricator

Fix misc GitHub issues related to Dagit UI
ClosedPublic

Authored by bengotow on Oct 1 2019, 7:34 PM.

Details

Reviewers
alangenfeld
Group Reviewers
Restricted Project
Commits
R1:ba131858ae36: Fix misc GitHub issues related to Dagit UI
Summary

Submitting these as a single diff because they all impact the snapshot tests and would merge conflict each other...

#1769: Default to the light theme if no theme is provided to ConfigTypeSchema
https://github.com/dagster-io/dagster/issues/1769

#1766: Don’t allow free-text search tokens that are an empty string (match all runs)
https://github.com/dagster-io/dagster/issues/1766

#1757: Allow the execution UI to be rendered with no data for better empty state
https://github.com/dagster-io/dagster/issues/1757

#1756: Use overscroll: auto where preferable for always-visible scrollbars
https://github.com/dagster-io/dagster/issues/1756

Update tests

Test Plan

Run snapshot tests

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bengotow created this revision.Oct 1 2019, 7:34 PM
alangenfeld accepted this revision.Oct 1 2019, 8:08 PM
This revision is now accepted and ready to land.Oct 1 2019, 8:08 PM
This revision was automatically updated to reflect the committed changes.