Page MenuHomePhabricator

use autoincrementing id for run storage sort order
ClosedPublic

Authored by prha on Tue, Oct 1, 6:09 AM.

Details

Reviewers
schrockn
Group Reviewers
Restricted Project
Commits
R1:3793af87c681: use autoincrementing id for run storage sort order
Summary

Does not include migration scripts, will require dropping existing tables

Test Plan

Ran run storage tests

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

prha created this revision.Tue, Oct 1, 6:09 AM
prha updated this revision to Diff 5268.Tue, Oct 1, 6:18 AM

pylint

prha updated this revision to Diff 5269.Tue, Oct 1, 6:43 AM

unique constraint

prha edited the summary of this revision. (Show Details)Tue, Oct 1, 6:58 AM
prha added a reviewer: Restricted Project.
schrockn accepted this revision.Tue, Oct 1, 2:19 PM
schrockn added a subscriber: schrockn.

migration scripts seem overkill. thanks for taking care of this

python_modules/dagster/dagster_tests/core_tests/test_run_storage.py
211

startreknod

This revision is now accepted and ready to land.Tue, Oct 1, 2:19 PM
This revision was automatically updated to reflect the committed changes.