Page MenuHomePhabricator

Test Postgres-backed DagsterInstance
ClosedPublic

Authored by max on Mon, Sep 30, 10:37 PM.

Details

Reviewers
alangenfeld
Group Reviewers
Restricted Project
Commits
R1:99a76f80bcc5: Test Postgres-backed DagsterInstance
Summary

Adds a basic test for the Postgres-backed DagsterInstance and cleans up our test setup for docker-compose tests. This test is still not passing on Buildkite -- the container networking solution here isn't adequate -- so disabling it on CI for now.

Test Plan

Unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
max added a comment.Tue, Oct 1, 4:55 PM

Unskip for bk

max updated this revision to Diff 5281.Tue, Oct 1, 5:12 PM

debug

max updated this revision to Diff 5284.Tue, Oct 1, 5:19 PM

0.0.0.0

max updated this revision to Diff 5285.Tue, Oct 1, 5:24 PM

Debug

max updated this revision to Diff 5286.Tue, Oct 1, 5:26 PM

debug

max updated this revision to Diff 5287.Tue, Oct 1, 5:30 PM

ps -a

Harbormaster failed remote builds in B4261: Diff 5286!
max updated this revision to Diff 5307.Tue, Oct 1, 7:36 PM

Test setup

max updated this revision to Diff 5312.Tue, Oct 1, 8:07 PM

Styx

max updated this revision to Diff 5314.Tue, Oct 1, 8:22 PM

Arghgh

max updated this revision to Diff 5315.Tue, Oct 1, 8:30 PM

docker-compose

max updated this revision to Diff 5317.Tue, Oct 1, 8:37 PM

Nits

max updated this revision to Diff 5319.Tue, Oct 1, 8:42 PM

Nits

max updated this revision to Diff 5327.Tue, Oct 1, 9:29 PM

debug

max updated this revision to Diff 5329.Tue, Oct 1, 9:44 PM

debug

max updated this revision to Diff 5333.Tue, Oct 1, 10:04 PM

Omgwtf

max updated this revision to Diff 5336.Tue, Oct 1, 10:24 PM

Connection strings

max updated this revision to Diff 5337.Tue, Oct 1, 10:25 PM

Rebase

max updated this revision to Diff 5342.Tue, Oct 1, 10:37 PM

network

max updated this revision to Diff 5376.Wed, Oct 2, 2:32 PM

Skip test on buildkite

max edited the summary of this revision. (Show Details)Wed, Oct 2, 2:34 PM
max added reviewers: alangenfeld, Restricted Project.
max updated this revision to Diff 5378.Wed, Oct 2, 2:47 PM

Nits

alangenfeld accepted this revision.Wed, Oct 2, 3:03 PM

finallydone

.buildkite/pipeline.py
123–135

i would rename this docker_compose_steps or something since it doesnt work the same as the other with_ in the file

python_modules/libraries/dagster-postgres/dagster_postgres_tests/conftest.py
65–80

add a link to a github task

This revision is now accepted and ready to land.Wed, Oct 2, 3:03 PM
max updated this revision to Diff 5406.Wed, Oct 2, 5:38 PM

Nits

max updated this revision to Diff 5410.Wed, Oct 2, 5:50 PM

Rebase