Page MenuHomePhabricator

Add RunStorage interface to DagsterInstance and reconcile naming
ClosedPublic

Authored by schrockn on Mon, Sep 30, 9:54 PM.

Details

Summary

Enforce consistency by adding RunStorage to DagsterInstance.
Changed some names as result

Resolves https://github.com/dagster-io/dagster/issues/1770

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Mon, Sep 30, 9:54 PM
prha added a comment.EditedMon, Sep 30, 10:12 PM

I actually prefer switching from all_runs* => get_runs*... instead of the other way around. What do you think?

(in fact, created D1128 before i saw this diff)

get_runs_with_XXXX makes the most sense of me

schrockn updated this revision to Diff 5239.Mon, Sep 30, 10:25 PM

prha name suggestions

prha accepted this revision.Mon, Sep 30, 10:28 PM
This revision is now accepted and ready to land.Mon, Sep 30, 10:28 PM