Page MenuHomePhabricator

[pylint] signature-mutators
ClosedPublic

Authored by alangenfeld on Sep 25 2019, 4:53 PM.

Details

Reviewers
schrockn
Group Reviewers
Restricted Project
Commits
R1:f240b116e01e: [pylint] signature-mutators
Summary

Use signature-mutators to communicate that @solid etc change function args.

Test Plan

lint

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Sep 25 2019, 4:53 PM
natekupp added inline comments.
.pylintrc
23

do we need to document for our users to do this with their .pylintrc as well?

docs/sections/learn/tutorial/hello_world.rst
25

should delete this comment entirely

❤️❤️❤️❤️❤️❤️❤️❤️

schrockn accepted this revision.Sep 25 2019, 4:59 PM
This revision is now accepted and ready to land.Sep 25 2019, 4:59 PM
alangenfeld added inline comments.Sep 25 2019, 4:59 PM
.pylintrc
23

composite_solid and lambda_solid are more debatable here since *most* of the time you should be passing all the args in. Not sure which side I fall on for whether to squelch here or at each callsite.

schrockn added inline comments.Sep 25 2019, 5:01 PM
.pylintrc
23

when are the cases where the arguments don't match?

alangenfeld added inline comments.Sep 25 2019, 5:08 PM
.pylintrc
23

leaving inputs unset that are provided at config time

alangenfeld added inline comments.Sep 25 2019, 5:31 PM
.pylintrc
23

bout 25 callsites if i remove lambda and composite

alangenfeld updated this revision to Diff 4960.Sep 25 2019, 5:33 PM

clean up docs comment

schrockn accepted this revision.Sep 25 2019, 5:38 PM
schrockn added inline comments.
.pylintrc
23

oh right ofc. yeah thats def a support use case so let's leave it in

This revision was automatically updated to reflect the committed changes.