Page MenuHomePhabricator

handle keyboard interrupts in inprocess engine
ClosedPublic

Authored by alangenfeld on Sep 20 2019, 9:18 PM.

Details

Reviewers
max
Group Reviewers
Restricted Project
Commits
R1:ef42f94648d0: handle keyboard interrupts in inprocess engine
Summary

Noticed this issue when ctrl+c-ing log_spew pipeline in dagster CLI

Test Plan

new unit test

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Sep 20 2019, 9:18 PM
alangenfeld edited the summary of this revision. (Show Details)Sep 20 2019, 9:32 PM
alangenfeld added a reviewer: Restricted Project.
alangenfeld edited the test plan for this revision. (Show Details)Sep 20 2019, 9:38 PM
max accepted this revision.Fri, Sep 20, 10:10 PM
max added a subscriber: max.
max added inline comments.
python_modules/dagster/dagster/core/engine/engine_inprocess.py
262

maybe worth adding something to the comment

This revision is now accepted and ready to land.Fri, Sep 20, 10:10 PM
alangenfeld updated this revision to Diff 4963.Wed, Sep 25, 6:11 PM

adjust timings for test

This revision was automatically updated to reflect the committed changes.