Page MenuHomePhabricator

Simplify EventLogStorage API
ClosedPublic

Authored by max on Tue, Sep 17, 11:36 PM.

Details

Summary

Removes the has_run and new_run methods. This would make the decoupling between EventLogStorage and RunStorage more evident; new_run was already (before D1049) a noop in every implementation.

Test Plan

Unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

max created this revision.Tue, Sep 17, 11:36 PM
alangenfeld added inline comments.Wed, Sep 18, 3:13 PM
python_modules/dagster/dagster/core/storage/event_log.py
178–181

how do we make sure the table is created?

max retitled this revision from RFC: Simplify EventLogStorage API to Simplify EventLogStorage API.Wed, Sep 18, 6:59 PM
alangenfeld accepted this revision.Wed, Sep 18, 8:00 PM
alangenfeld added inline comments.
python_modules/dagster/dagster/core/storage/event_log.py
147–150

is this an issue when it happens from multiple threads? i guess not since we do CREATE TABLE IF NOT EXISTS

consider refactor to separate function or share the same connection as below

This revision is now accepted and ready to land.Wed, Sep 18, 8:00 PM
max updated this revision to Diff 4842.Wed, Sep 18, 8:05 PM

Rebase

This revision was automatically updated to reflect the committed changes.