Page MenuHomePhabricator

make instance arg on execute_plan_iterator non-optional
ClosedPublic

Authored by alangenfeld on Sep 13 2019, 9:49 PM.

Details

Reviewers
max
Group Reviewers
Restricted Project
Commits
R1:6f625b268a25: make instance arg on execute_plan_iterator non-optional
Summary

plan related calls should have instance created already

Test Plan

buildkite

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Sep 13 2019, 9:49 PM
alangenfeld edited the summary of this revision. (Show Details)Sep 13 2019, 9:52 PM
alangenfeld updated this revision to Diff 4800.Sep 17 2019, 6:42 PM

test call sites

alangenfeld added a reviewer: Restricted Project.Sep 17 2019, 8:18 PM
max accepted this revision.Sep 17 2019, 11:36 PM
max added a subscriber: max.

๐Ÿ†—

This revision is now accepted and ready to land.Sep 17 2019, 11:36 PM
This revision was automatically updated to reflect the committed changes.