Page MenuHomePhabricator

Replace runs search bar with a nice autocompleting tokenized field

Authored by bengotow on Sep 13 2019, 4:15 PM.



This stacks on D985 and converts the search bar on the runs page to a tokenizing typeahead that suggests searchable keys and then suggests values.

Test Plan

Run snapshot tests

Diff Detail

R1 dagster
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bengotow created this revision.Sep 13 2019, 4:15 PM
prha accepted this revision.Sep 13 2019, 10:38 PM
prha added a subscriber: prha.

style nit: otherwise things look good

style nit 2: can you implement an onblur event so that we can't have both popups open:

This happens if you tab out of the filter input into the sort input.

Also, the build errors look spurious, but can you retry to make sure before merging?


set default value false, to be explicit?

This revision is now accepted and ready to land.Sep 13 2019, 10:38 PM
bengotow updated this revision to Diff 4766.Sep 16 2019, 4:50 PM

Rebase and address feedback

Good catchβ€”I switched this over to using onFocus and onBlur on the input to manage the open / close state rather than inheriting behavior from the popover and that seems to work much better!


Ahh good call πŸ‘

bengotow updated this revision to Diff 4767.Sep 16 2019, 4:52 PM

Rebuild snapshot tests

This revision was landed with ongoing or failed builds.Sep 16 2019, 5:30 PM
This revision was automatically updated to reflect the committed changes.