Page MenuHomePhabricator

remove feature flags for dagit log viewer
ClosedPublic

Authored by prha on Sep 11 2019, 10:11 PM.

Details

Reviewers
schrockn
Group Reviewers
Restricted Project
Commits
R1:dd776a420109: remove feature flags for dagit log viewer
Summary

With DagsterInstance, we have a good fallback for storing logs.
We also have POSIX support for mirroring output in the stdout stream.

(can also defer this until we get a Windows mirror solution)

Test Plan

Ran without DAGSTER_HOME set, saw logs being set

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

prha created this revision.Sep 11 2019, 10:11 PM
schrockn accepted this revision.Sep 11 2019, 10:14 PM
schrockn added a subscriber: schrockn.

makeitso

This revision is now accepted and ready to land.Sep 11 2019, 10:14 PM
prha updated this revision to Diff 4733.Sep 13 2019, 6:26 PM

rebase

prha updated this revision to Diff 4744.Sep 13 2019, 9:13 PM

handle mocked-out stdout / stderr streams for failing tests

prha updated this revision to Diff 4748.Sep 13 2019, 9:47 PM

make stdout/stderr stream readable, for pytest compliance

This revision was automatically updated to reflect the committed changes.