Page MenuHomePhabricator

Keep track of registered operations on a connection context
ClosedPublic

Authored by prha on Wed, Sep 11, 1:04 AM.

Details

Summary

We're not keeping track of which operations have stopped, which means
we keep sending messages back to the client after they have stopped listening
to them

Test Plan

Loaded runs view, with compute logging, debug logged the event
handlers along with registered state

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

prha created this revision.Wed, Sep 11, 1:04 AM
alangenfeld added inline comments.
python_modules/dagit/dagit/subscription_server.py
72–73

??

alangenfeld requested changes to this revision.Wed, Sep 11, 4:26 PM

to your queue

This revision now requires changes to proceed.Wed, Sep 11, 4:26 PM
prha added inline comments.Wed, Sep 11, 5:58 PM
python_modules/dagit/dagit/subscription_server.py
72–73

I can remove this conditional branch...

Rolling my own Subscriber implementation ended up being pretty gnarly because of all of the Rx operator support, so I might punt on it for the time being

prha updated this revision to Diff 4628.Wed, Sep 11, 9:50 PM

update

This revision is now accepted and ready to land.Thu, Sep 12, 5:16 PM
This revision was automatically updated to reflect the committed changes.