Page MenuHomePhabricator

refactor compute log link to minimize refetching
ClosedPublic

Authored by prha on Sep 11 2019, 12:53 AM.

Details

Reviewers
alangenfeld
Group Reviewers
Restricted Project
Commits
R1:850be72f2146: refactor compute log link to minimize refetching
Summary

Moves some of the fetching logic behind some conditionals

Test Plan

Loaded log viewer

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

prha created this revision.Sep 11 2019, 12:53 AM
prha updated this revision to Diff 4585.Sep 11 2019, 12:55 AM

fix tests

prha added a reviewer: Restricted Project.Sep 11 2019, 1:24 AM
alangenfeld accepted this revision.Sep 11 2019, 4:24 PM
alangenfeld added a subscriber: alangenfeld.

verygood

This revision is now accepted and ready to land.Sep 11 2019, 4:24 PM
This revision was automatically updated to reflect the committed changes.