After lambda_solid is removed publicly, we want to keep it around as an internal API? Why?
We can find the real underlying issue using https://dagster.phacility.com/D4975, the migration error is masking the true cause
got it. I reopen-ed https://github.com/dagster-io/dagster/issues/3169 for tracking if you want to put failures somewhere
ok I no longer think that was it, I'm seeing this in other tests that use instance_for_test :) there's something funky going on with the event log.
Ok, I'm going to merge this because I think it's still an improvement over our current state, even if there's opportunity for visual improvement.
remove mention of removing module in 0.10.0 since i'm not positive that's actually the plan
Should note that we are removing tests for rendering the type page, solids page, and playground. But let's burn it down. Curious to see what testing structure you have in mind...
- Prunes buildkite steps to only include integration tests.
- Adds dependency injection for k8s client on dagster-k8s run launcher.
- Fix the pruned buildkite pipeline. 0
- Fixes pruned buildkite pipeline. 1
comments and rebase
switch to --package-name
This makes a lot of sense to me.
other than the name this seems good to me, see inline. We can also do a single diff at the end of this stack where we do a big codemod to make all the final naming decisions, since we're going back and forth so much and renaming through a stack is a pain
we should take out the 's' otherwise this looks good :)
other than the naming stuff this is looking good to me, and we can do a rename pass at the end of the stack too. @alangenfeld did you have any blockers left here?