Page MenuHomePhabricator

Open Tasks

  • No tasks found.

Active Repositories

Recent Activity

Yesterday

sandyryza added a comment to D5268: fix fan-in input mappings in composites.

When you say "fixing things", is there a github issue or something that describes what needs to be fixed?

Thu, Nov 26, 4:43 PM
yichendai updated the diff for D5225: Fix schreenshots test: Part 1.

Update: Allow a hover error to be seen and fix all the new URLs

Thu, Nov 26, 1:18 AM
sandyryza accepted D5257: enable reexecution when all required asset stores are non mem.

Looks good! It feels like there are some tricky edge cases here, e.g. if only some inputs of a solid come from a prior run, so maybe worth thinking through if there are tests to write that would give us confidence on them.

Thu, Nov 26, 12:25 AM

Wed, Nov 25

sashank requested review of D5306: [dagit] Remove refetch from WorkspaceContext.
Wed, Nov 25, 11:18 PM
sashank closed D5299: Fix apollo cache reset race condition.
Wed, Nov 25, 10:59 PM
sashank committed R1:1d91ee8bccdb: Fix apollo cache reset race condition (authored by sashank).
Fix apollo cache reset race condition
Wed, Nov 25, 10:59 PM
sashank updated the diff for D5299: Fix apollo cache reset race condition.

Add comment

Wed, Nov 25, 10:59 PM
GitHub <noreply@github.com> committed R1:e70dfb6fa235: Update README.md (authored by Yichen <59324923+nancydyc@users.noreply.github.com>).
Update README.md
Wed, Nov 25, 10:58 PM
sashank added inline comments to D5299: Fix apollo cache reset race condition.
Wed, Nov 25, 10:57 PM
alangenfeld added a comment to D5291: [RFC] Cancel queued runs.

just throwing some ideas around -

  • we add column to run storage, user_action, user_override or something like that
  • add a new event type, not engine event, that corresponds
  • run storage response to this new event does a smart column update so that it is only written from "origin host process" ie dagit and shouldn't conflict with other writes
  • add a new API (which we could use for other reasons) of instance.get_run_row_by_id to allow fetching the full run row including this column
  • use this for cancel / terminate from the dequeuer / run worker
Wed, Nov 25, 10:46 PM
dgibson added a comment to D5291: [RFC] Cancel queued runs.

If we do that it should cover terminated too IMO

Wed, Nov 25, 10:31 PM
alangenfeld added a comment to D5291: [RFC] Cancel queued runs.

nit: reported something as "failed" that never started feels weird to me - i think an explicit canceled state may be worth it

Wed, Nov 25, 10:28 PM
alangenfeld added a comment to D5291: [RFC] Cancel queued runs.

oof ya the race conditions here are really gnarly. Probably worth drawing up the full state machine diagram. I feel like we need to have a safer overall scheme like @dgibson is talking about. I think delete and mark-as-failed are emergency escape hatches that may put the system in to a bad state if the user does them at the wrong time. In all other cases there should be a clear "owner" for the run and only that "owner" should manage transitions.

Wed, Nov 25, 10:22 PM
yuhan retitled D5257: enable reexecution when all required asset stores are non mem from enable reexecution when 'asset_store' is set to enable reexecution when all required asset stores are non mem.
Wed, Nov 25, 10:14 PM
bengotow requested review of D5292: Fix "View Asset Dashboard" link using href={} for a local app route.
Wed, Nov 25, 10:04 PM
johann updated the diff for D5120: Daemon heartbeats backend.

up

Wed, Nov 25, 10:03 PM
sashank added a comment to D5304: Fix undo functionatlity in Dagit playground.

Double check that switching tabs in the editor doesn't create a continuous undo history

Wed, Nov 25, 10:00 PM
schrockn updated the diff for D5271: Refactor configured infrastructure to eliminate "underscore" params on public definitions.

up

Wed, Nov 25, 10:00 PM
schrockn updated the diff for D5271: Refactor configured infrastructure to eliminate "underscore" params on public definitions.

up

Wed, Nov 25, 9:51 PM
Harbormaster failed remote builds in B21798: Diff 26478 for D5120: Daemon heartbeats backend!
Wed, Nov 25, 9:47 PM
sashank updated the diff for D5304: Fix undo functionatlity in Dagit playground.

up

Wed, Nov 25, 9:46 PM
bengotow added a comment to D5304: Fix undo functionatlity in Dagit playground.

This patch package is pretty intriguing. I'm OK with doing this in this isolated instance because we're likely to abandon codemirror at some point in the future (for Monaco) and forking / fixing the library to make this change seems like overkill. I'm curious to get @dish 's thoughts + approval on this though because he investigated that change.

Wed, Nov 25, 9:45 PM
schrockn requested review of D5271: Refactor configured infrastructure to eliminate "underscore" params on public definitions.
Wed, Nov 25, 9:38 PM
sashank published D5304: Fix undo functionatlity in Dagit playground for review.
Wed, Nov 25, 9:35 PM
alangenfeld closed D5302: del stale todo.
Wed, Nov 25, 9:32 PM
alangenfeld committed R1:e6845016df37: del stale todo (authored by alangenfeld).
del stale todo
Wed, Nov 25, 9:32 PM
sashank accepted D5302: del stale todo.
Wed, Nov 25, 9:31 PM
johann updated the diff for D5120: Daemon heartbeats backend.

up

Wed, Nov 25, 9:30 PM
alangenfeld requested review of D5302: del stale todo.
Wed, Nov 25, 9:12 PM
sashank closed D4808: (config-scaffold 2/n) Add scaffold config button to Dagit playground.
Wed, Nov 25, 9:09 PM
sashank committed R1:1d3359632e5f: (config-scaffold 2/n) Add scaffold config button to Dagit playground (authored by sashank).
(config-scaffold 2/n) Add scaffold config button to Dagit playground
Wed, Nov 25, 9:09 PM
sashank updated the diff for D4808: (config-scaffold 2/n) Add scaffold config button to Dagit playground.

up

Wed, Nov 25, 9:01 PM
sashank updated the diff for D4808: (config-scaffold 2/n) Add scaffold config button to Dagit playground.

up

Wed, Nov 25, 8:46 PM
prha committed R1:7f347aecd782: fix toy sensor directory name (authored by prha).
fix toy sensor directory name
Wed, Nov 25, 8:45 PM
prha closed D5301: fix bug in toy sensor.
Wed, Nov 25, 8:38 PM
prha committed R1:dee511780178: fix bug in toy sensor (authored by prha).
fix bug in toy sensor
Wed, Nov 25, 8:38 PM
dish accepted D5301: fix bug in toy sensor.
Wed, Nov 25, 8:37 PM
prha published D5301: fix bug in toy sensor for review.
Wed, Nov 25, 8:37 PM
sashank updated the diff for D4808: (config-scaffold 2/n) Add scaffold config button to Dagit playground.

up

Wed, Nov 25, 8:34 PM
GitHub <noreply@github.com> committed R1:c13015272dc2: Update bug_report.md (authored by Yichen <59324923+nancydyc@users.noreply.github.com>).
Update bug_report.md
Wed, Nov 25, 8:31 PM