Page MenuHomePhabricator

Recent Activity

Today

nate added a comment to D4487: Add retries to S3 object store client.

I don't know how best to test this, but see https://boto3.amazonaws.com/v1/documentation/api/latest/guide/retries.html

Sat, Sep 19, 3:38 AM
nate requested review of D4487: Add retries to S3 object store client.
Sat, Sep 19, 3:35 AM

Yesterday

Harbormaster failed remote builds in B18516: Diff 22476 for D4465: Use version resolution logic for result versions!
Fri, Sep 18, 11:36 PM
Harbormaster failed remote builds in B18514: Diff 22473 for D4444: Only allow grpc run termination in user code!
Fri, Sep 18, 11:18 PM
sandyryza updated the diff for D4465: Use version resolution logic for result versions.

up

Fri, Sep 18, 11:06 PM
sandyryza accepted D4482: added solid required_resource_keys to executionstep.
Fri, Sep 18, 11:05 PM
prha closed D4467: TriggeredExecutionDefinition => ExecutableDefinition.
Fri, Sep 18, 11:02 PM
prha committed R1:fe9ce517ebef: TriggeredExecutionDefinition => ExecutableDefinition (authored by prha).
TriggeredExecutionDefinition => ExecutableDefinition
Fri, Sep 18, 11:02 PM
dgibson updated the diff for D4444: Only allow grpc run termination in user code.

test fix

Fri, Sep 18, 11:02 PM
prha committed R1:d3874896e7d0: ExecutablePipeline => IPipeline (authored by prha).
ExecutablePipeline => IPipeline
Fri, Sep 18, 11:00 PM
prha closed D4458: ExecutablePipeline => IPipeline.
Fri, Sep 18, 11:00 PM
prha renamed Image Macro "flatcircle" from timeisaflatcircle to flatcircle.
Fri, Sep 18, 10:59 PM
sandyryza committed R1:0301692f934c: document DagsterEvent attribute types (authored by sandyryza).
document DagsterEvent attribute types
Fri, Sep 18, 10:31 PM
sandyryza closed D4485: document DagsterEvent attribute types.
Fri, Sep 18, 10:31 PM
sandyryza added a comment to D4481: passed version param to ResourceDefinition.

When I run into small bugs like this, I normally try to include a test that would have caught the bug in the first place. Might be easy to add or augment something in test_resource_definitions.

Fri, Sep 18, 10:07 PM
dish committed R1:fd2862b956c6: Split dagit frontend build steps from main pipeline (authored by dish).
Split dagit frontend build steps from main pipeline
Fri, Sep 18, 10:04 PM
dish closed D4466: Split dagit frontend build steps from main pipeline.
Fri, Sep 18, 10:04 PM
dish updated the diff for D4466: Split dagit frontend build steps from main pipeline.

Hmm try this again

Fri, Sep 18, 9:58 PM
Harbormaster failed remote builds in B18511: Diff 22467 for D4466: Split dagit frontend build steps from main pipeline!
Fri, Sep 18, 9:54 PM
alangenfeld accepted D4458: ExecutablePipeline => IPipeline.

elmofire

Fri, Sep 18, 9:47 PM
sandyryza accepted D4473: Make lazy-loading user code in the gRPC server a flag that's set in managed gRPC servers only.
Fri, Sep 18, 9:45 PM
alangenfeld accepted D4467: TriggeredExecutionDefinition => ExecutableDefinition.

movingshitaround

Fri, Sep 18, 9:44 PM
Harbormaster failed remote builds in B18510: Diff 22466 for D4444: Only allow grpc run termination in user code!
Fri, Sep 18, 9:43 PM
alangenfeld accepted D4485: document DagsterEvent attribute types.

thankyou

Fri, Sep 18, 9:41 PM
dish updated the diff for D4466: Split dagit frontend build steps from main pipeline.

+alangenfeld

Fri, Sep 18, 9:41 PM
alangenfeld accepted D4473: Make lazy-loading user code in the gRPC server a flag that's set in managed gRPC servers only.

nit: lazy_load_user_code to at least specify what is being lazy loaded

Fri, Sep 18, 9:40 PM
dish updated the diff for D4466: Split dagit frontend build steps from main pipeline.

Comment

Fri, Sep 18, 9:40 PM
alangenfeld accepted D4466: Split dagit frontend build steps from main pipeline.

illallowit

Fri, Sep 18, 9:39 PM
alangenfeld added inline comments to D4466: Split dagit frontend build steps from main pipeline.
Fri, Sep 18, 9:39 PM
dish added inline comments to D4466: Split dagit frontend build steps from main pipeline.
Fri, Sep 18, 9:38 PM
dish retitled D4466: Split dagit frontend build steps from main pipeline from [RFC] Split dagit frontend build steps from main pipeline to Split dagit frontend build steps from main pipeline.
Fri, Sep 18, 9:37 PM
Harbormaster failed remote builds in B18509: Diff 22465 for D4444: Only allow grpc run termination in user code!
Fri, Sep 18, 9:33 PM
sandyryza requested review of D4479: Implement get_addresses_for_step_output_versions for SQL event storage.
Fri, Sep 18, 9:33 PM
dgibson updated the diff for D4444: Only allow grpc run termination in user code.

up

Fri, Sep 18, 9:28 PM
Harbormaster failed remote builds in B18507: Diff 22463 for D4336: Add dbt cli module!
Fri, Sep 18, 9:21 PM
dgibson updated the diff for D4444: Only allow grpc run termination in user code.

alex's feedback:

Fri, Sep 18, 9:19 PM
sandyryza requested review of D4485: document DagsterEvent attribute types.
Fri, Sep 18, 9:19 PM
sandyryza added inline comments to D4480: Added full solid versioning support to step selection..
Fri, Sep 18, 9:17 PM
bob updated the diff for D4336: Add dbt cli module.
  • Extracts output from dbt compile without causing Python member errors.
  • Adds logger attribute to DbtRpcClient.
  • Revert "Extracts output from dbt compile without causing Python member errors." and "Adds logger attribute to DbtRpcClient.
  • Adds @experimental to CLI solids.
  • Improve descriptions on CLI flag configs.
  • Removes Python 2 classifier.
Fri, Sep 18, 9:07 PM
prha requested review of D4483: fix relative links in module docs.
Fri, Sep 18, 8:58 PM