Page MenuHomePhabricator

Open Tasks

  • No tasks found.

Active Repositories

Recent Activity

Today

sandyryza added a comment to D4868: RFC: deprecate imports of lambda_solid from top level.

After lambda_solid is removed publicly, we want to keep it around as an internal API? Why?

Fri, Oct 30, 5:17 PM
dgibson added a comment to D4972: use instance_for_test in test_event_callback function.

We can find the real underlying issue using https://dagster.phacility.com/D4975, the migration error is masking the true cause

Fri, Oct 30, 5:04 PM
schrockn added a comment to D4972: use instance_for_test in test_event_callback function.

got it. I reopen-ed https://github.com/dagster-io/dagster/issues/3169 for tracking if you want to put failures somewhere

Fri, Oct 30, 4:32 PM
dgibson added a comment to D4972: use instance_for_test in test_event_callback function.

ok I no longer think that was it, I'm seeing this in other tests that use instance_for_test :) there's something funky going on with the event log.

Fri, Oct 30, 4:22 PM
sandyryza closed D4749: Reform docs frontpage.
Fri, Oct 30, 4:13 PM
sandyryza committed R1:1f1181378ba3: Reform docs frontpage (authored by sandyryza).
Reform docs frontpage
Fri, Oct 30, 4:13 PM
sandyryza added a comment to D4749: Reform docs frontpage.

Ok, I'm going to merge this because I think it's still an improvement over our current state, even if there's opportunity for visual improvement.

Fri, Oct 30, 4:12 PM
Harbormaster failed remote builds in B20524: Diff 24885 for D4911: Differentiate between ModuleCodePoitner and PackageCodePointer on the gRPC server!
Fri, Oct 30, 4:09 PM
dgibson updated the diff for D4916: Add a RepositoryLocationOrigin class that separates out the loading instructions for a repo location from the actual repository data that it loads.

lint

Fri, Oct 30, 3:54 PM
dgibson updated the diff for D4911: Differentiate between ModuleCodePoitner and PackageCodePointer on the gRPC server.

remove mention of removing module in 0.10.0 since i'm not positive that's actually the plan

Fri, Oct 30, 3:52 PM
dish closed D4931: Upgrade Apollo.
Fri, Oct 30, 3:45 PM
dish committed R1:bfc8f0940c51: Upgrade Apollo (authored by dish).
Upgrade Apollo
Fri, Oct 30, 3:45 PM
Harbormaster failed remote builds in B20518: Diff 24877 for D4916: Add a RepositoryLocationOrigin class that separates out the loading instructions for a repo location from the actual repository data that it loads!
Fri, Oct 30, 3:44 PM
dish updated the diff for D4931: Upgrade Apollo.

Rebase

Fri, Oct 30, 3:38 PM
dish closed D4969: [dagit] Empty definition state for empty pipelines.
Fri, Oct 30, 3:30 PM
dish committed R1:4c4699076e22: [dagit] Empty definition state for empty pipelines (authored by dish).
[dagit] Empty definition state for empty pipelines
Fri, Oct 30, 3:30 PM
dish added a comment to D4931: Upgrade Apollo.

Should note that we are removing tests for rendering the type page, solids page, and playground. But let's burn it down. Curious to see what testing structure you have in mind...

Fri, Oct 30, 3:30 PM
bob updated the diff for D4889: Uses run tags instead of external pipeline tags for user defined k8s config..
  • Prunes buildkite steps to only include integration tests.
  • Adds dependency injection for k8s client on dagster-k8s run launcher.
  • Fix the pruned buildkite pipeline. 0
  • Fixes pruned buildkite pipeline. 1
Fri, Oct 30, 3:19 PM
dgibson added reviewers for D4968: Add run IDs to the list of runs in grpcrunlauncher used for test cleanup, even if the launch failed: max, prha, schrockn.
Fri, Oct 30, 3:17 PM
dgibson updated the diff for D4916: Add a RepositoryLocationOrigin class that separates out the loading instructions for a repo location from the actual repository data that it loads.

comments and rebase

Fri, Oct 30, 3:17 PM
dpeng817 <cdguitar817@gmail.com> closed D4954: Test for python set's dagstertypeloader.
Fri, Oct 30, 3:07 PM
dpeng817 <cdguitar817@gmail.com> committed R1:da9b8de14434: Test for python set's dagstertypeloader (authored by dpeng817 <cdguitar817@gmail.com>).
Test for python set's dagstertypeloader
Fri, Oct 30, 3:07 PM
dgibson updated the diff for D4911: Differentiate between ModuleCodePoitner and PackageCodePointer on the gRPC server.

switch to --package-name

Fri, Oct 30, 3:00 PM
prha accepted D4969: [dagit] Empty definition state for empty pipelines.
Fri, Oct 30, 2:31 PM
prha requested changes to D4941: Split RepositoryOrigin/PipelineOrigin hierarchy into ExternalOrigins and PythonOrigins.

This makes a lot of sense to me.

Fri, Oct 30, 2:30 PM
prha accepted D4931: Upgrade Apollo.

push_n_pray

Fri, Oct 30, 1:51 PM
prha added a comment to D4931: Upgrade Apollo.

This looks good.

Fri, Oct 30, 1:51 PM
dgibson requested changes to D4915: [run-queue-5] Default runs coordinator (sends to external process).

other than the name this seems good to me, see inline. We can also do a single diff at the end of this stack where we do a big codemod to make all the final naming decisions, since we're going back and forth so much and renaming through a stack is a pain

Fri, Oct 30, 1:41 PM
dgibson accepted D4903: [run-queue-4] Make runs coordinator an instance concept.

we should take out the 's' otherwise this looks good :)

Fri, Oct 30, 1:35 PM
dgibson added a comment to D4891: [Run-queue-3] LaunchImmediateRunsCoordinator.

other than the naming stuff this is looking good to me, and we can do a rename pass at the end of the stack too. @alangenfeld did you have any blockers left here?

Fri, Oct 30, 1:31 PM
dish updated the diff for D4931: Upgrade Apollo.

Rebase

Fri, Oct 30, 1:18 PM
dish closed D4961: [dagit] Flip UTC offset sign in timezone picker.
Fri, Oct 30, 1:17 PM
dish committed R1:147d8493c4af: [dagit] Flip UTC offset sign in timezone picker (authored by dish).
[dagit] Flip UTC offset sign in timezone picker
Fri, Oct 30, 1:17 PM
dish closed D4970: [dagit] Use Table for /scheduler.
Fri, Oct 30, 1:16 PM
dish committed R1:4767a8ce2fad: [dagit] Use Table for /scheduler (authored by dish).
[dagit] Use Table for /scheduler
Fri, Oct 30, 1:16 PM
dgibson added inline comments to D4973: Fix test_sync_list_container_grpc running locally outside of BK.
Fri, Oct 30, 1:07 PM
max abandoned D4199: RFC: @dagster_type decorator.
Fri, Oct 30, 7:01 AM
max requested review of D4945: Load from module when possible in reconstructable.
Fri, Oct 30, 6:59 AM
max requested review of D4868: RFC: deprecate imports of lambda_solid from top level.
Fri, Oct 30, 6:57 AM
dgibson updated the diff for D4974: telemetry cleanup attempt.

up

Fri, Oct 30, 3:31 AM